search

leonid-shevtsov / headless

Create a virtual X screen from Ruby, record videos and take screenshots.
http://leonid.shevtsov.me/en/headless
MIT License
968 stars 113 forks source link

Add rubocop integration #61

Closed ShockwaveNN closed 9 years ago

ShockwaveNN commented 9 years ago

Hello @leonid-shevtsov. I run rubocop on this project and fix some trivial cases (mostly by rubocop auto-correct), but manually verified all results.

If you're interested in this results, I can continue to fix rubocop warnings in this pull request and make code better.

leonid-shevtsov commented 9 years ago

I appreciate the effort, but I won't merge 200 changed lines just to fix linter issues.

But, thanks for the suggestion to use rubocop - I've now enabled it in my editor and will eventually correct issues in changed lines.

ShockwaveNN commented 9 years ago

Ok. It's your chose, I just mention, that I done same job in rubyzip and don't know about any troubles introduced in those code-style fixes. And there was almost 1700 lines of changes :)

leonid-shevtsov commented 9 years ago

For me it's not about troubles, it's about code churn.