search

leonjia0112 / ec601_passenger_screening

1 stars 1 forks source link

Code Review - Rohan #17

Closed Rohanjadeja closed 6 years ago

Rohanjadeja commented 6 years ago

Hi,

Most codes are easily readable and well commented in each individual branch. The master branch contains most of the final codes so that helped.

Most of my concerns about data sources and the images you used for training you model but since it is a kaggle projects and this point was already taken up in class I think I'll just have to read up about it on kaggle.

The training model seems to be giving good results with over 90% of hit accuracy. It'd be great if you guys could mention you dataset size used with the training and testing fractions for the same. I'd love to a description of how each code segment is put together as well, but it seems like you guys have done a great job at it! Cheers!

gvikram31 commented 6 years ago

Hello Rohan,

Thanks a lot for the feedback.

-- Vikram