Feature/guzzlehttp upgrade

leonjza / PHPNessusNG

PHP wrapper functions for interfacing with the Nessus V6.x API

MIT License

15 stars 9 forks source link

Closed pdscopes closed 7 years ago

pdscopes commented 7 years ago

PHPNessusNG was still using Guzzle ~v3.0, this PR will bring it up to using ~v6.0 (the latest version of Guzzle).

These changes should make no difference to a user of PHPNessusNG except that they will be able to use Guzzle 6 with PHPNessusNG.

leonjza commented 7 years ago

Whoop nice! 👍
Will test and merge asap.

leonjza commented 7 years ago

Have to check, but I think configureProxy might be broken with Guzzle 6 (just the way its implemented).

pdscopes commented 7 years ago

Do you still think that configureProxy might be broken? I based the changes I made from: http://docs.guzzlephp.org/en/latest/request-options.html#query but don't have a proxy to test it on.

leonjza commented 7 years ago

Let me rather test it first before I make more comments :D It might be totally fine.