search

leonlatsch / Photok

Encrypted Photo Safe for Android
Apache License 2.0
502 stars 49 forks source link

[Feature] Material You / Dynamic colors support #328

Open starry-shivam opened 3 months ago

starry-shivam commented 3 months ago

Is your feature request related to a problem? Please describe. Well, it's not strictly related to a problem, but it'll be a nice addition. Since most apps support dynamic themes already, it results in a consistent user experience, and I think it also looks quite nice.

Describe the solution you'd like Adding dynamic/Material You theme support.

Describe alternatives you've considered N/A

Additional context I can probably work on this and create a PR after getting the green signal.

leonlatsch commented 3 months ago

👍

For Photok, Material 3 usage is pretty new, so I just created a fixed color theme. Feel free to try it. Keep in mind, that not all of Photok is migrated to compose yet, so it will only apply to Gallery, Albums and the main menu for now.

starry-shivam commented 3 months ago

not all of Photok is migrated to compose yet, so it will only apply to Gallery, Albums and the main menu for now.

Yeah, I realized it just now after taking a look at the source code. However, I think we can add a fallback Material You theme for the XML views to keep it consistent. I'll give it a try after #318 and see how it goes.