leonoel / missionary

A functional effect and streaming system for Clojure/Script
Eclipse Public License 2.0
620 stars 25 forks source link

Cancel in example for basic walkthrough doesn't work #88

Closed joshcho closed 11 months ago

joshcho commented 11 months ago
(def a-task (m/sleep 15000 :done))
(def cancel (a-task #(println :ok %)
                    (fn [_] (println :KO))))
(cancel a-task)                         ; exception
;; probably (cancel)
leonoel commented 11 months ago

(cancel) is the correct form. Where is this example from ?

joshcho commented 11 months ago

Halfway down this page: https://github.com/leonoel/missionary/wiki/Basic-Walkthrough:-Tasks-&-Flows

On Sun, Aug 6, 2023 at 4:38 PM Léo NOEL @.***> wrote:

(cancel) is the correct form. Where is this example from ?

— Reply to this email directly, view it on GitHub https://github.com/leonoel/missionary/issues/88#issuecomment-1666759147, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABRSRXBDI2G6JQX7V63TZ2TXT5CVVANCNFSM6AAAAAA3FXRKQE . You are receiving this because you authored the thread.Message ID: @.***>

leonoel commented 11 months ago

I fixed the wiki page. Thanks for reporting !