Switch from `log` to `tracing`

leontoeides / google_maps

An unofficial Google Maps Platform client library for the Rust programming language.

https://crates.io/crates/google_maps

Apache License 2.0

58 stars 24 forks source link

Switch from `log` to `tracing` #7

Closed seanpianka closed 3 years ago

seanpianka commented 3 years ago

We currently use log for logging, but we also pull in tracing through Hyper, and the nesting structure of tracing might be a good fit for us anyway. So, we should switch to tracing everywhere.

Proposal

Replace all uses of the log crate with tracing (there are verbatim replacements for the logging macros, so no code changes)
Replace all uses of {:?} in tracing macro invocations with ?value infront of the format string

leontoeides commented 3 years ago

That's a good idea. I think I will do this through a feature flag maybe?

seanpianka commented 3 years ago

I think it would be fine to migrate entirely away from log in the crate's implementation, and enable certain log compatibility features within tracing to enable backwards compatibility in existing 2.0.0 users.

See this section on migrating from log to tracing for an idea of what the migration might look like.

leontoeides commented 3 years ago

Very cool! Look at all of these newfangled things you're introducing me to. Thank you! I've merged your request, added support for tracing, tested it, and published the crate.