search

leopard-js / leopard

Library for making Scratch-like projects with JavaScript.
https://leopardjs.com
MIT License
136 stars 26 forks source link

Fix how speech bubbles get cleared and handle interruptions correctly #170

Open towerofnix opened 1 year ago

towerofnix commented 1 year ago

See discussion here: https://github.com/leopard-js/leopard/pull/146#discussion_r1127933998

From @adroitwhiz:

After pondering this for a bit, I've come to the conclusion that this code has actually just been subtly broken the whole time. If another thread comes along and clears the speech bubble timeout, the done flag will never be set and we'll be stuck waiting forever.

Let's just rewrite this entirely in another PR.