leopard-js / leopard

Library for making Scratch-like projects with JavaScript.
https://leopardjs.com
MIT License
145 stars 27 forks source link

Misc. fixes for pick() and "when this sprite clicked" #173

Closed towerofnix closed 1 year ago

towerofnix commented 1 year ago

Fixes #164 and the "when this sprite clicked" generally not functioning at all.

This is basically a hand-picked cherry basket from #146, where the same fixes are made across several commits (of debugging). Thanks to @adroitwhiz for figuring out most of this!

This is a quick patch PR so we can release this fix sooner.

towerofnix commented 1 year ago

@adroitwhiz I'm not sure whether you prefer to merge or rebase, but since all these fixes are already implemented in #164, you should be able to just keep all of your changes and none of these when merging/rebasing and have everything work OK. I hope! My git-fu isn't quite thorough enough :P

I've tested this all works correctly so just getting your code review on principle. Lemme know if there's something obvious I missed 📦

towerofnix commented 1 year ago

Totally reviewed. Yus.