leopard-js / sb-edit

Javascript library for manipulating Scratch project files
MIT License
50 stars 13 forks source link

toLeopard: Code style cleanup for blockToJS & related functions #124

Closed towerofnix closed 5 months ago

towerofnix commented 6 months ago

This pull request cleans up the code style contained by and surrounding blockToJS in a number of fairly high-impact ways, which together make it far easier to incrementally edit block definitions, compare one block to another, and generally read and understand the codebase. See individual commits; in summary:

This PR basically doesn't change any behavior, apart from a few logic tidiness mentioned above, and the change to how order of operations is expressed. Since the latter has always been collaped by prettier, this doesn't affect sb-edit output at all — only how the code is expressed.

A neat way of reviewing this would probably be to view the diff in the "side by side" / split view appearance (rather than with additions and subtractions all in one column).

PullJosh commented 5 months ago

There have been a lot of commits since a new release on npm. Is it time to do that soon?

towerofnix commented 5 months ago

We haven't been in a rush for it since none of these are behavior changes, but the housekeeping stuff does clean up dependencies and update our name on the license - if you'd like to put a release online then everything is certainly good to go as-is.

122 will probably be ready tomorrow, with the fix for #123 shortly after... but if pushing an extra NPM release is no hassle, then there's not much reason to wait pending those. ^^

towerofnix commented 5 months ago

We may have forgotten that tomorrow is Christmas eve, LOL. Well, you know: those pull requests will be set when they're set, and that'll be sooner rather than later. Happy holidays! ✨ 📦

PullJosh commented 5 months ago

Lol. Maybe we wait for #122 and #123 because I don't remember the entire pushing process. Happy holidays! 📦