leopard-js / sb-edit

Javascript library for manipulating Scratch project files
MIT License
55 stars 15 forks source link

toLeopard: Review uses of "any"-shape inputs for string operations #152

Open towerofnix opened 4 months ago

towerofnix commented 4 months ago

There are various places where we use InputShape.Any (or inputToJS without any desired traits, after #150) for inputs that would ostensibly take or expect strings. Sometimes this might be alright - but shouldn't these all be string inputs? Wouldn't some of them error if a number-like literal gets converted to a JS number primitive? Demands investigation.