leopard-js / sb-edit

Javascript library for manipulating Scratch project files
MIT License
50 stars 13 forks source link

Update TypeScript and enable strict mode #94

Closed adroitwhiz closed 5 months ago

adroitwhiz commented 1 year ago

Resolves #92 Resolves #97

This PR updates TypeScript to the latest release (4.9), updates Prettier to the next major version, and enables strict mode.

Some externally-visible changes have been made to the codebase:

I haven't touched the Leopard serialization code yet, since #90 touches it a lot. I'll go over it and un-draft this PR once it's merged.

adroitwhiz commented 1 year ago

PS: While any (existing) code style issues can be noted, I don't think they should be blockers here. I see this PR as a prerequisite to other changes (including fixing those issues), and fixing #100 will mean re-coding a substantial portion of this project regardless, which will likely bulldoze over any code style issues.

towerofnix commented 5 months ago

Since we've gone through a thorough review of this earlier, I'm calling this good to merge.

There are loads of force pushes above on my part - sorry about that! These were to fix unaddressed lint and snapshot issues in-place as they cropped up, rather than later commits. The history should be good here now, it just took a couple tries to get right. ^^;