leopardslab / clocal-gcp

🔭 Emulation engine for GCP
Apache License 2.0
67 stars 57 forks source link

Add command registering using readdir #42

Closed emgaurv closed 5 years ago

emgaurv commented 5 years ago

graphical demo

emgaurv commented 5 years ago

@rehrumesh Please Review.

rehrumesh commented 5 years ago

@hcktheheaven your approach is correct. However here you have coded some hardcoded array indexes. So whenever we add a new service we will need to update the code. If you can fix that I will be happy to merge this.

emgaurv commented 5 years ago

@rehrumesh @rajikaimal I've Removed the Hard coded hardcoded array indexes & now it is totally Dynamic. Please Review. screenshot

rehrumesh commented 5 years ago

LGTM 👍 @dilantha111 Review, please.