search

leopardslab / gocloud

☁️ Go API for open cloud
Apache License 2.0
119 stars 142 forks source link

Error in test cases & Naming suggestion for AWS LoadConfig() #49

Closed OddCN closed 6 years ago

OddCN commented 6 years ago

Issue Overview

In auth package, the auth.LoadConfig() function already renamed as auth.AWSLoadConfig(). But int test cases such as compute/ec2/instance_test.go, container/awscontainer/container_test.go, etc.Inside the init() function of the test cases is still the previous method - auth.LoadConfig().

Suggestion

Rename auth.AWSLoadConfig() as awsAuth.LoadConfig(), and fix usages 's name of this package function. This will be more applicable to other auth of cloud naming, such as aliAuth.LoadConfig(), azureAuth.LoadConfig().

shlokgilda commented 6 years ago

The suggestions do make sense. If everyone agrees to the naming conventions, I believe that we can go ahead with this.

PratikDhanave commented 6 years ago

+1

shlokgilda commented 6 years ago

Should we start using the naming convention suggested for further development?