search

leopck / Yee-Light-Blue

Writing library for yee light blue using python for raspberry pi
32 stars 7 forks source link

Mark davison uws patch 1 #4

Closed MarkDavisonUWS closed 7 years ago

MarkDavisonUWS commented 7 years ago

Added function for controlling white colour temperature and brightness of YeeLight Blue II bulb. "CLTMP 6500,100,,,," is much much brighter than "255,255,255,100,,,". Usage x.white(temperature,brightness) Modeled on original code, arguments are strings. temperature '1700' to '6500' brightness '0' to '100'

Indentation ok in my version but in pull request looks wrong on line 82, hopefully that's obvious.

leopck commented 7 years ago

no worries, i think the line 82 just looks bad on the commit page.

is this commit for Yee Light Blue 2?

leopck commented 7 years ago

oops just checked, it is for yee light blue 2

leopck commented 7 years ago

Technically, we should perform a check before I merge, but since I do not own a yee light blue 2. I can't perform a test. For now, I'll merge in and if there's any issues, someone will point it out and we'll do something about it then. Thanks for contributing!