leoroese / reacthookform-v7-ts-materialui-tutorial

React Hook Form with Typescript and Material UI Tutorial Repo
MIT License
45 stars 19 forks source link

Where is husky? #1

Open RajS999 opened 2 years ago

RajS999 commented 2 years ago

Am not seasoned web developer. I was going through your react-hook-form videos. I came across eslint, prettier libraries. I have explored them a bit. Now I am going through your repository but I am not able to find husky mentioned anywhere. Most of the tutorials (1,2,3) online explains invoking lintstaged inside husky's pre commit hook. Isnt husky hooks compulsory for lintstaged to work? Or you simply plan to invoke lint-staged manually by directly typing in the terminal?

leoroese commented 2 years ago

Hey there,

You should be able to invoke lint-staged within the pre commit hook by adding npx lint-staged so long as it is configured / installed in your package.json

Get Outlook for iOShttps://aka.ms/o0ukef


From: RajS999 @.> Sent: Monday, February 28, 2022 12:49:15 PM To: leoroese/reacthookform-v7-ts-materialui-tutorial @.> Cc: Subscribed @.***> Subject: [leoroese/reacthookform-v7-ts-materialui-tutorial] Where is husky? (Issue #1)

Am not seasoned web developer. I was going through your react-hook-form videos. I came across eslint, prettier libraries. I have explored them a bit. Now I am going through your repository but I am not able to find husky mentioned anywhere. Most of the tutorials (1https://laurieontech.com/posts/husky/,2https://thomaslombart.com/setup-eslint-prettier-react,3https://stackoverflow.com/questions/51748246/is-this-a-right-way-to-use-husky-lint-staged) online explains invoking lintstaged inside husky's pre commit hook. Isnt husky hooks compulsory for lintstaged to work? Or you simply plan to invoke lint-staged manually by directly typing in the terminal?

— Reply to this email directly, view it on GitHubhttps://github.com/leoroese/reacthookform-v7-ts-materialui-tutorial/issues/1, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADK3DSBSZ45GHN6H5MTDTHDU5UIKXANCNFSM5PR4N66A. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you are subscribed to this thread.Message ID: @.***>

RajS999 commented 2 years ago

But that is not what you are doing, right? Or that is what you are indeed doing in this repo? Because I didnt find you configuring this anywhere in package.json? So was guessing if am missing something and unable to spot the pre-commit hook configuration in this repo.