leosac / access-control-web

Leosac Access Control - Open Source Physical Access Control System - Web Frontend
https://leosac.com
GNU Affero General Public License v3.0
8 stars 2 forks source link

Hardcoded secret key #2

Open Asterius27 opened 1 month ago

Asterius27 commented 1 month ago

Hello,

We are a cybersecurity research group from the CISPA Helmholtz Center for Information Security and Ca’ Foscari University of Venice. We recently conducted an analysis of the session management used in your web application as part of our research. We have discovered a security vulnerability that we believe requires your attention.

Vulnerability Description:

After our analysis, we have identified that your application is using a hard-coded secret key that is leaked through GitHub. If operators who install your web application do not change this secret key, they are vulnerable to cookie forgeries. The cookie forgery attack allows an attacker, knowing the key used to sign a cookie, to forge new arbitrary cookies to impersonate and take over other accounts.

link to the relevant code part

Recommendation for Mitigation:

To address this vulnerability and enhance the security posture of your web application, we highly recommend setting the secret key from an environment variable. If the environment file is not shared on GitHub then this would force operators of your application to create their own key upon installation, forcing them to set their own secure secret key.

We hope this notification helps improve your security. Can you take a look into the relevant code parts and comment on the issue?

Maxhy commented 1 month ago

This is not a security vulnerability as this code (everything related to flask on this repo) is just an example on how to build a cloud service on top of leosac access control, not being used in production nowadays.

Thanks for the report anyway.