search

leosac / access-control

Leosac Access Control - Open Source Physical Access Control System
https://leosac.com
GNU Affero General Public License v3.0
240 stars 40 forks source link

disable stacktrace when building release #113

Closed knight-of-ni closed 6 years ago

knight-of-ni commented 6 years ago

When CMAKE_BUILD_TYPE=Release is set, debug symbols are intentionally removed from the build.

However, leosac fills the log with many messages stating missing debug info:

[2018-02-12 13:08:40.724] [console] [error] [5076] Problem when generating stacktrace: no debug info in ELF executable. Error code: -1

Setting the LEOSAC_STACKTRACE_DISABLED flag in debian rules silences these warnings.

NOTE: Perhaps we should set LEOSAC_STACKTRACE_DISABLED in CMakeLists.txt if CMAKE_BUILD_TYPE=Release. If we build Release rather than Debug, I can't think of a case where we want to see ever these messages.

xaqq commented 6 years ago

NOTE: Perhaps we should set LEOSAC_STACKTRACE_DISABLED in CMakeLists.txt if CMAKE_BUILD_TYPE=Release

I think you're right we could do that indeed.