search

leoshaw / rubyripper

Automatically exported from code.google.com/p/rubyripper
0 stars 0 forks source link

Single file FLAC errors on invalid character (double quote) in ISRC data field in cuesheet #547

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
1) Please describe the steps to reproduce the situation:
a. Relevant preferences: "Rip CD to single file," codec flac
b. "Rip CD Now!"

2) What is the expected output? What do you see instead?
Output directory left with cue file and log, but no flac. There isn't an 
indication of problem in the log file (I'm not sure why flac isn't returning an 
error). Eventually traced back to FLAC complaining about invalid characters in 
the ISRC data fields.

3) What version of rubyripper are you using? On what operating system? The
gtk2 of commandline interface?
Occurs in both CLI and GTK. Currently using git master branch, SHA 
abd1b52bba74b5716599bdfae767d4db97adc488

4) Is this not already fixed with the latest & greatest code? See for
instructions the Source tab above.
Nope.

5) Does the problem happen with all discs? If not, please attach
the output of cdparanoia -Q with a disc that gives trouble.
Happens with all discs I've tried

6) Please explain why this change is important for you. Also, how many
users would benefit from this change?
Prevents all flac ripping

Please provide any additional information below. The more useful
information provided, the sooner the issue will be fixed.
I've attached a patch that removes the quote. I'm unschooled on the ruby 
testing stuff, so please review the files in spec!

Note that ruby versions older than 1.9 are no longer supported. You are
advised to upgrade instead.

Original issue reported on code.google.com by jmbyl...@gmail.com on 23 Dec 2012 at 5:00

Attachments:

GoogleCodeExporter commented 9 years ago 
Thanks for the patch, though I only applied the cuesheet fixes. The cdrdao file 
parsing is correct I believe since it really does use quotes.

http://code.google.com/p/rubyripper/source/detail?r=61a20cc8135a101cb80afc447489
fdd7170d5116

Original comment by boukewou...@gmail.com on 27 Dec 2012 at 7:50

GoogleCodeExporter commented 9 years ago 
Works correctly now. Thanks!

Original comment by jmbyl...@gmail.com on 29 Dec 2012 at 10:30