search

leoshusar / mat_month_picker_dialog

Flutter Material month picker dialog
MIT License
3 stars 7 forks source link

Add: locale and builder to showMonthPicker #1

Closed MayLau-CbL closed 1 year ago

MayLau-CbL commented 1 year ago

Hi @leoshusar! I have been using the material month picker package you created, which is really good and simple. Since I have some cases that required me to dynamically change the locale and the theme of the dialog in run time. I have forked your repository and added the locale and builder to showMonthPicker function like what the current flutter date time picker did. Since other developers may also have needs to do this, I make a PR here to see if you would like to include these updates:

  1. added locale and builder to showMonthPicker
  2. removed unused cupertino import
  3. applied the latest dart format to whole source
leoshusar commented 1 year ago

Hi @MayLau-CbL, thank you for your contribution!

Just one thing, could you please set the version to 1.1.0 instead of 1.0.2? According to semantic versioning, the last number (patch) is for bug fixes and the middle one (minor) is for new backwards compatible functionalities. I think this would classify as a new functionality.

MayLau-CbL commented 1 year ago

Thanks for the review, @leoshusar! i have updated the version number to 1.1.0 😆

leoshusar commented 1 year ago

It's up, thank you! 😁