leosongwei / mutagen

Automatically exported from code.google.com/p/mutagen
GNU General Public License v2.0
0 stars 0 forks source link

mutagen does not always close files (breaks when using pypy) #111

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
A couple of tests fail when running the testsuite (using "setup.py test") with 
pypy 1.8. Two changes are necessary to get them to pass, both adding a missing 
f.close() call. (Files are closed when garbage-collected, and they are 
garbage-collected immediately after the last reference goes away in CPython but 
not in some other implementations like PyPy.)

I'm attaching a svn diff (against r108) that looks much more intimidating than 
it really is, as I'm adding a try/finally block, shifting a bunch of code one 
indentation level to the right. "svn diff -x -uw" after applying it is much 
more readable.

Original issue reported on code.google.com by marien.z...@gmail.com on 2 Jun 2012 at 11:24

Attachments:

GoogleCodeExporter commented 9 years ago
Looks good

Original comment by reiter.christoph@gmail.com on 19 Jul 2012 at 10:56

GoogleCodeExporter commented 9 years ago
This issue was closed by revision r109.

Original comment by reiter.christoph@gmail.com on 19 Jul 2012 at 12:21