Malformed FLAC Vorbis header causes out of memory error

leosongwei / mutagen

Automatically exported from code.google.com/p/mutagen

GNU General Public License v2.0

0 stars 0 forks source link

Malformed FLAC Vorbis header causes out of memory error #112

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago

Some malformed FLAC file headers can cause out of memory on certain systems 
(for example Debian squeeze). Other systems raise MemoryError, which probably 
is not desirable.

This patch fixes use of range in VComment to xrange, thus working in constant 
memory space.

Note that use of xrange is not compatible with Python 3.

I've attached patch and a FLAC with headers that cause OOMing

Original issue reported on code.google.com by jy...@spotify.com on 25 Jun 2012 at 7:35

Attachments:

GoogleCodeExporter commented 9 years ago

Looks good.

Updated patch to include a link to this issue.

Original comment by reiter.christoph@gmail.com on 19 Jul 2012 at 11:05

Attachments:

xrange-v2.patch

GoogleCodeExporter commented 9 years ago

This issue was closed by revision r110.

Original comment by reiter.christoph@gmail.com on 19 Jul 2012 at 3:00

Changed state: Fixed

GoogleCodeExporter commented 9 years ago

[deleted comment]

GoogleCodeExporter commented 9 years ago

If you tell me your name I can add it to the NEWS file

Original comment by reiter.christoph@gmail.com on 19 Jul 2012 at 3:01

GoogleCodeExporter commented 9 years ago

Hi, my name is Jyrki Pulliainen. Thanks for including the patch! :)

Original comment by jy...@spotify.com on 31 Jul 2012 at 3:26