leosongwei / mutagen

Automatically exported from code.google.com/p/mutagen
GNU General Public License v2.0
0 stars 0 forks source link

TXXX support in mid3v2 #62

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Would be very useful to me.

Original issue reported on code.google.com by tim.goo...@phipps-hutton.freeserve.co.uk on 27 Apr 2010 at 7:59

GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
Here's a patch for enabling editing of TXXX frames in mid3v2.

More in the discussion pages.

http://groups.google.com/group/quod-libet-development/browse_thread/thread/32d26
fc8fc44b583

Karl

Original comment by g...@heimskringla.com on 18 Sep 2010 at 2:19

Attachments:

GoogleCodeExporter commented 9 years ago
I'm not sure this patch works with every version of mid3v2, so I will attach 
here the version I use, with comments. 

I know, I know, you're not supposed to submit entire files, that are not patch 
files, but this is just for making it easier to examine.

Karl

Original comment by g...@heimskringla.com on 21 Sep 2010 at 9:46

Attachments:

GoogleCodeExporter commented 9 years ago
Thanks, mid3v2-TXXX-fix works nicely but it reports itself as version 1.1. The 
version in SVN is 1.3 and is quite a bit different which is why the patch 
doesn't work.

Original comment by tim.goo...@phipps-hutton.freeserve.co.uk on 21 Sep 2010 at 12:28

GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
Are you sure about TXXX support in mid3v2_1.3. I've just run svn update, purged 
my system of other mutagens and run this:

./mid3v2 --TXXX "bingle:bongle" test.mp3

and got this:

eyeD3 test.mp3

test.mp3        [ 5.63 MB ]
-------------------------------------------------------------------------------
Time: 03:06     MPEG1, Layer III        [ ~253 kb/s @ 44100 Hz - Joint stereo ]
-------------------------------------------------------------------------------
ID3 v2.4:
title:          artist:
album:          year: None
track:

UserTextFrame: [Description: None]
bingle:bongle

Note the Description is None instead of bingle.

Original comment by tim.goo...@phipps-hutton.freeserve.co.uk on 22 Sep 2010 at 10:48

GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
I'm sorry, I was wrong. Maybe out of laziness and impatience. It seems I didn't 
clean out all the old files properly, which gave erroneous results.

TXXX is NOT supported yet. The fix is easy, so I beg the administrators to 
include this as soon as possible. It is necessary as there is no other command 
line utility that can handle TXXX writing properly. eyeD3 can write TXXX tags, 
but corrupts other tags. And eyeD3 is not maintained anymore.

Meanwhile, you can do the following:

If you have mid3v2 1.1 then use the above mid3v2-v1.1+mut1.15.patch to patch 
the existing /usr/bin/mid3v2 (or wherever it is. Use "which mid3v2").

Or you can use the above mid3v2-TXXX-fix to replace the existing mid3v2. Or use 
the new file locally, of course.

On the other hand, if you have mid3v2 1.3 (the SVN version) then use either the 
new patch-file () below or the new replacement file () in a similar way.

Hope I got it right *this* time. Please test, please get back.

Karl

Original comment by g...@heimskringla.com on 22 Sep 2010 at 6:39

Attachments:

GoogleCodeExporter commented 9 years ago
Syntax for adding user-defined text data using an updated mid3v2 should be: 

mid3v2 -x  "DESCRIPTION:TEXT"
mid3v2 --usertext  "DESCRIPTION:TEXT"
mid3v2 --TXXX  "DESCRIPTION:TEXT"

Original comment by g...@heimskringla.com on 22 Sep 2010 at 7:27

GoogleCodeExporter commented 9 years ago
Here's a patch that just extends txxx. Note the 'elif frame == COMM' which 
fixes the hash error; and the 'split(":", 1)' which allows colons in the rest 
of the text.

Original comment by tim.goo...@phipps-hutton.freeserve.co.uk on 24 Sep 2010 at 3:32

Attachments:

GoogleCodeExporter commented 9 years ago
Great!

I tested it and mid3v2 is working as expected. It's also an improvement to the 
earlier patch. 

In this case the only syntax would be:

mid3v2 --TXXX "DESCRIPTION:TEXT"

which is enough and perfectly alright.

The man file part has a slight formatting error, though. 

-TXXX "replaygain_track_gain:-9.35 dB" 

should be

\-\-TXXX "replaygain_track_gain:-9.35 dB"

(Surrounded by \fB  \fR for bold text would be even better)

Original comment by g...@heimskringla.com on 24 Sep 2010 at 7:12

GoogleCodeExporter commented 9 years ago
Fixed the man page and also simplified the TXXX code.

Original comment by phipps.s...@gmail.com on 28 Sep 2010 at 9:15

Attachments:

GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
r97.

Original comment by joe.wreschnig@gmail.com on 30 Oct 2010 at 2:57