Loading id3 tagged files with a large padding is slow

leosongwei / mutagen

Automatically exported from code.google.com/p/mutagen

GNU General Public License v2.0

0 stars 0 forks source link

Loading id3 tagged files with a large padding is slow #65

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago

Some of my albums have songs with a large padding (~55640 frames each,
probably itunes).
Loading one song takes 0.6s.

The problem is that ID3.__determine_bpi checks all frames.

The following patch stops reading if it reaches a padding and uses the size
of the left data % 10 to calculate the offset.

Load time with patch: 0.05s

Original issue reported on code.google.com by reiter.christoph@gmail.com on 25 May 2010 at 9:27

Attachments:

bpi_padding.patch

GoogleCodeExporter commented 9 years ago

This issue was closed by revision r88.

Original comment by joe.wreschnig@gmail.com on 13 Jul 2010 at 3:58

Changed state: Fixed