Commands with uppercase names are not supported

leostera / tldr.jsx

📚 A Reactive web client for tldr-pages

https://tldr.ostera.io

MIT License

1.54k stars 75 forks source link

Commands with uppercase names are not supported #166

Open sbrl opened 3 years ago

sbrl commented 3 years ago

Currently, tldr.ostera.io doesn't support command names that contain uppercase letters. For example eyeD3 and R.

A discussion was had on Gitter, and we suspect the following lines of code are at fault:

https://github.com/ostera/tldr.jsx/blob/d1efe52eb77bde1b179f4eb0780f2060847ba199/src/render.js#L19 (in particular)
https://github.com/ostera/tldr.jsx/blob/d1efe52eb77bde1b179f4eb0780f2060847ba199/src/components/Link.js#L23 (visually only)

MasterOdin commented 3 years ago

To add here, the site supports direct linking to the page, but does not support typing in the name if it has capitals. For example, if I go to https://tldr.ostera.io/R it works, if I type in "R" into the search bar, it takes me to https://tldr.ostera.io/r and fails. As @sbrl, this is probably do to the toLowerCase() that happens on updating the browser history as you type.