search

leotaku / kojirou

Generate perfectly formatted Kindle e-books from MangaDex manga
MIT License
94 stars 9 forks source link

Fix file output parameter #3

Closed Colin1224 closed 2 years ago

Colin1224 commented 2 years ago

Currently the argument for setting output directory, -o, doesn't do anything when set. This fix creates a path from the given string and amends it to the beginning of the output file. If an output directory is not specified then there is no change, but if one is specified then all outputs are written to the given directory. Accounts for trailing slash. Tested on Windows 10 and Ubuntu 20.04 LTS (WSL2).

leotaku commented 2 years ago

Hi, thank you for creating this PR! Unfortunately, I already have implemented this functionality in a local branch. Also, I'm currently very busy with exams, so sorry for keeping you waiting.

I'll try getting around to fixing up my changes and pushing them soon. When I do that, I will also add you as a co-author so you get credited for your help. Thanks again!