leotaku / web-push-native

Pure rust implementation of web-push and related standards
Apache License 2.0
6 stars 1 forks source link

feat!: use concrete error type in `web_push` #3

Closed ThinkChaos closed 1 year ago

ThinkChaos commented 1 year ago

Box<dyn std::error::Error> is not recommended for libraries as it makes it difficult for consumers to deal with errors. Using thiserror helps making a custom error type painless, and thiserror doesn't appear in the API at all.

leotaku commented 1 year ago

Addressed in #5