leotiger / grav-plugin-backup-manager

An Enanced Backup Manager for Grav
MIT License
15 stars 3 forks source link

Some comments #3

Open Sommerregen opened 7 years ago

Sommerregen commented 7 years ago

Hi @leotiger ,

I really appreciate your plugin and like it :+1: . However, I noticed a few issues, improvements and (minor) bugs.

Except of those points (and the access rights you are currently implementing), it is really a nice plugin. Well done!

leotiger commented 7 years ago

Hi @Sommerregen

  1. If you open a test zip you will see that it only contains the folder structure, same goes for purge requests, you will see how many zips would be deleted but they won't be deleted actually. Only if you run the process using the Live Run Button that shows up on top, the process will be executed.

What's the reason behind? I encountered backup problems with the Grav built-in backup, 50% of the backups did not terminate correctly and this was caused by a lot of libraries I placed in my instance for development purposes. Failed backups left invalid files behind that consumed a lot of space and moreover, nothing showed up in the interface. Summarized: Test mode is useful in two conditions, to fine-tune your backup before turning-off test-mode and as a safe-guard.

  1. Yeah, that's what config is all about. To offer a "support backup". You will also see a phpinfo.html in the backup directory of the zip file.

  2. With CLI you can do that, no problem. CLI offers more options than those exposed in the admin interface. But it would be nice to offer this through admin as well. There are a lot of possibilities to improve here.

  3. CLI is available for this, the rest as in 3.

  4. That's true and that's one of the possible enhancements for the next updates

  5. Access rights are already available in 0.1.2. I fixed the route related problem. You can offer a reduced backup to users with the permission admin.backup-manager. This offers at the moment the possibility to backup media, images and pages to those users.

Regards und Grüsse. u

leotiger commented 7 years ago

@Sommerregen

I updated the plugin. Version 0.1.3 includes some bug fixes and minor improvements.