Submission for assignment 3 - Githubissues

leotran20 / df-frontend-2023

https://df-frontend-2023-rho.vercel.app

0 stars 0 forks source link

Submission for assignment 3 #3

Open leotran20 opened 1 year ago

leotran20 commented 1 year ago

Hi, this is demo link for my submission for assignment 3: https://df-frontend-2023-a3.vercel.app/

In this assignment, I have:

converted my assignment 2 to Typescript.
integrated Eslint for better coding standards.
ensured meeting all the requirements of the previous assignments.

Please take a moment to review my work, and I would greatly appreciate your feedback. Thank you for your time and effort!

trankhacvy commented 11 months ago

Hello @leotran20 , nice work but there is room for improvement!

Requirements

[x] All core functionalities present
[ ] Proper TypeScript implementation
[x] No eslint warnings & errors
[ ] Husky & lint-staged integration !!

Final result: ❌ Failed

Feedback

We also have some comments for your work:

Some functions don't have types. If you turn on the noImplicitAny setting, you can easily find them. Think about adding types to them.

https://github.com/leotran20/df-frontend-2023/blob/490f2edef212562880cec23ff08a7163ce26c31a/assignment-3/src/App.tsx#L80

https://github.com/leotran20/df-frontend-2023/blob/490f2edef212562880cec23ff08a7163ce26c31a/assignment-3/src/App.tsx#L91

You have a few JavaScript files in your project. Think about converting them into TypeScript files.
It's not recommended to use variables outside of components in React. Think about converting them into React state.

https://github.com/leotran20/df-frontend-2023/blob/490f2edef212562880cec23ff08a7163ce26c31a/assignment-3/src/App.tsx#L16C1-L16C1

There are some issues and bug that I pointed out in the previous assignment, and they haven't been addressed in this assignment. Please take your time to fix these issues.