search

leovandriel / cvplot

Graph plots, drawing, layout and windows in OpenCV
MIT License
122 stars 26 forks source link

hi #1

Closed sturkmen72 closed 2 years ago

sturkmen72 commented 6 years ago

this will be a nice contribution if you think to contribute OpenCV library

leovandriel commented 6 years ago

Hi, thanks for suggesting. I didn't really think about doing that. Do you have any experience with contributing to OpenCV?

sturkmen72 commented 6 years ago

yes, i can help on refactoring your code according to OpenCV's code style.

leovandriel commented 6 years ago

great. what changes do you think we need?

sturkmen72 commented 6 years ago

I roughly looked at the code you wrote. for example some variable types can be converted to common OpenCV's variable types etc. Also probably OpenCV's core developers like @vpisarev and @alalek will guide us to better refactoring

sturkmen72 commented 6 years ago

are you a student?

leovandriel commented 6 years ago

not student. I was working on some personal project with deep learning in caffe2 and wanted to plot some graphs of the training accuracy. I was surprised there was nothing decent available, so had a go myself.

About the variable types: yes, it would be good to use opencv internal formats. In this project i deliberately tried to avoid use of opencv names in headers, so it would only require opencv for linking.