search

leowolf275 / pe

0 stars 0 forks source link

Wedding Event Ordering Issue #6

Open leowolf275 opened 4 days ago

leowolf275 commented 4 days ago

The UG clearly states that the ordering of the two partners of a wedding matters. However, I don't think this is a good solution because users might forget the order after they create the wedding event.

Hence, Alice & Bob should be equal to Bob & Alice.

Not only that, the app should give an error/warning message if the user wants to add a new wedding event with the same details.

For example, if I create a wedding for Jacob and Hannah, I should not be able to create a wedding for Hannah and Jacob, especially if they contain the same details (e.g. same date, same venue).

However,

after inputting the following two commands, no error message was displayed:

  1. add-wed w/Jacob & Hannah v/Orchard Hotel d/15/10/2022
  2. add-wed w/Hannah & Jacob v/Orchard Hotel d/15/10/2022

image.png

soc-pe-bot commented 20 hours ago

[IMPORTANT!: Please do not edit or reply to this comment using the GitHub UI. You can respond to it using CATcher during the next phase of the PE]

Team's Response

Screenshot 2024-11-18 at 1.22.18 AM.png

As mentioned in our UG, we do not consider them as duplicates and accept these types of inputs.

Implementing this will take a lot more work as it would affect every single of our wedding-related commands like view-wed, delete-wed, tag-add, tag-del etc.

We would have to validate the wedding names and their corresponding reverse if we were to address this, which is why we put it as not in scope.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your reason]