leozide / leocad

A CAD application for creating virtual LEGO models
https://www.leocad.org
2.49k stars 212 forks source link

New Parts properties widget 'Parts' combo dropdown has issues (WIP) #897

Open nathaneltitane opened 10 months ago

nathaneltitane commented 10 months ago

Describe the bug new parts widget 'Parts' list dropdown is a regression: cannot clearly distinguish in between part variants due to cropped description string

Reproduce: see screenshot

Expected behavior combo box llist items should take up all available width to make sure descriptions are clearly visible and not cropped

Screenshots

image

Version (please complete the following information):

nathaneltitane commented 10 months ago

@leozide kind of urgent?

nathaneltitane commented 9 months ago

@leozide bump - please?

nathaneltitane commented 9 months ago

Edit: selecting multpiple parts and clicking the colors combo on the new parts widget does nothing - the selection is blocked, cannot reassign colors to multiple parts at the same time...

this new prpoerties widget is a massive regression - please fix

leozide commented 9 months ago

It's not finished yet

nathaneltitane commented 9 months ago

It's not finished yet

i understand.

would be good to at least fix these couple things to make it worth the integration?

had to roll back to december continuous to be able to work and benefit from the new features.

nathaneltitane commented 9 months ago

In addition to the parts properties dropdown combo not being the full width of the widget panel it resides in, the filter function that was added to it is counterproductive as the input is not captured on click (resulting in requiring an additonal click to focus)

Another problem is that the filter does not seem to function as expected:

for instance, writing 'tile' does show all tile parts (even the unwanted or moved ones (which should be adressed once and for all under the parts options and reflect the same list of parts shown in the visual parts widget) but if i add another keyword to tile, such as 'inv'[erted], no result shows up...

The expected filter behavior should be to populate the list in a manner to refine search results down to the expected few parts one could select from.

I am still very much insistant on the fact that if the click to focus should remain to enable said filter, the old parts list combo behavior should still be present (de facto) to enable the user to simply type a letter or a sequence of letters representing the parts in the list to navigate through a little faster (you can test the behavior on older leocad versions).

The height of the combo should be maximized to use as much screen space as possible as the mouse scroll behavior and sensitivity throughtout various user setups also greatly affects scrolling throught the list and easily selecting the wanted part from the list without filtering.

EDIT:

it seems that an additional double click is also required now to confirm which part is being toggled from the parts list widget, which makes it even less desirable quite frankly...

image

image

image

image

nathaneltitane commented 5 months ago

Hi @leozide any ETA on this?

nathaneltitane commented 5 months ago

@leozide parts properties widget still too small after latest update/commit - why can'T it just be full widget width like its parent button and full window height like older releases...?

nathaneltitane commented 3 months ago

latest iteration is a great improvement @leozide : can the popup be scaled in width with the parent panels' width? same issue with color properties - they are tiny.

image

image

nathaneltitane commented 3 weeks ago

@leozide continuing on the newly improved parts properties widget:

the color selection palette is tiny on high resolution displays:

image

EDIT:

part search/change popup should also be a little bigger or at the very least manually editable (size-wise):

image

nathaneltitane commented 3 weeks ago

@leozide - another issue with the new parts properties widget:

1 - select a component for edit 2 - click on the part title 3 - type into search filed of popup (FIRST ISSUE: search filed should be focused to enable direct typing for faster search) 4 - type part name (SECOND ISSUE: visual part search entries are scrolled all the way down automatically after search - must scroll back up to get desired results...)

image

nathaneltitane commented 3 weeks ago

@app4soft can you confirm?

app4soft commented 3 weeks ago

new parts properties widget

To note, this widget is based on "Parts" list widget code, so some issues appears in both, "Parts" list and "Properties->Piece->Part" widgets.

3 - type into search filed of popup (FIRST ISSUE: search filed should be focused to enable direct typing for faster search)

Confirms.

For "Properties->Piece->Part" widgets, there should be an autofocus on "Search Part" input field — actually its unclear what is in focus (yet, even "Search Part" not in focus, tapping on keyboard scrolls to first one-three parts started with tapped key symbol).

4 - type part name (SECOND ISSUE: visual part search entries are scrolled all the way down automatically after search - must scroll back up to get desired results...)

For this I created an issue already, because same issue eixists in "Parts" list too:

(some time it scroll to up, some time it also scrolls to the middle of the list)

the color selection palette is tiny on high resolution displays:

Confirms.

Also, I suppose that color selection "Properties" widget should be in a form of dropdown list of colours (i.e. each color preview and full name+code should be entries of dropdown list) — no need to make it as duplicate of "Colors" widget (as it is now).

As a workaround/alternative way for HiDPI display, its possible to use "Colors" widget to select color and assign it to selected parts with a 'line button' located in the header of the "Colors" widget (its useful even for parts which can't be colored with bucket "Paint" in case if selected parts located inside the complex model).

leocad-colors-button

nathaneltitane commented 2 weeks ago

another issue with the parts widget i've come to notice, which may be part of a bigger underlying problem is that when searching for a part and attempting to refine the search criteria by adding words does not produce the expected results.

Example: 1 - select a component for replacment through the parts widget 2 - input word that is part of part description 3 - add space + another word also part of description 4 - LLIST RETURNS EMPTY

ball + ' ' + blind should normally return part 32474 ('Technic Ball Joint With AxleHole Blind')

also, this occurs when 'All parts' is selected (default) - changing the parts category does not influence the result - basically, anymore than one word for the search breaks the search function and returns nothing regardless of what is attempted)