lep / jassdoc

Document the WarCraft 3 API
52 stars 20 forks source link

Force API: describe DestroyForce, ForceEnumPlayers & small changes. #115

Closed Luashine closed 10 months ago

Luashine commented 10 months ago

ForceEnumPlayers broke my brain for a while.

I have not yet gone into player state and player slot state, so the description will be refined later because the enum skips player slots based on some logic.

Edit: Filtering function's crash in Lua is interpreted as "false", otherwise no error is thrown. It's silent

lep commented 10 months ago

Thanks. Looks good so far. Are you done with this or should i wait merging?

Edit: Filtering function's crash in Lua is interpreted as "false", otherwise no error is thrown. It's silent

What exactly do you mean by that? This should be consistent with jass behaviour; crashing in Filterfunc also returns false when evaluating it.

Luashine commented 10 months ago

Merge for now. I will come back to it later. I have a historic Jass timeline coming up and I wanted to integrate WorldEdit hints before I continue with popular old APIs.

This should be consistent with jass behaviour; crashing in Filterfunc also returns false when evaluating it.

Good to know, its just weird to have errors suppressed esp when you attempt to test stuff ;_;