search

lep / jassdoc

Document the WarCraft 3 API
52 stars 20 forks source link

common.j: Describe SetPlayerAlliance (enemy test) #123

Closed Luashine closed 9 months ago

Luashine commented 9 months ago

I'll soon finish writing this "tutorial" on Hive: "How to control enemy player's units (for play testing)"

Luashine commented 9 months ago

Huh looks like I made a branch on this repo, rather than my own... Oh GitHub Web :)

lep commented 9 months ago

Looks good to me. Except you probably wanted the example not be part of the value parameter. That's how the parser sees it currently.

Luashine commented 9 months ago

100%! Haha :) Feel free to fix those mistakes yourself if you want.

lep commented 9 months ago

100%! Haha :) Feel free to fix those mistakes yourself if you want.

Alright, will keep that in mind for the future. I just feel a bit uneasy about commiting to other peoples PRs.

Luashine commented 9 months ago

I just feel a bit uneasy about commiting to other peoples PRs.

I understand but sometimes it's not worth the back and forth commenting :heart: