search

lep / jassdoc

Document the WarCraft 3 API
52 stars 20 forks source link

Add patch annotations to everything #132

Closed Leyki closed 6 months ago

Luashine commented 6 months ago

This is awesome!

Why didn't you include the betas? But anyway I'll want to expand this (much much later now) to include basic diffing of blizzard.j / AI functions between patches too. I had asked and looked at using lep's jass2json to operate on AST but not only would it overcomplicate things just due to the AST part (sorry lep) but also require specialized, not readily available algorithms from compsci papers to create atomic tree-to-tree diffs. Looking at that, I had scaled down my idea to dumb string compare between Jass functions. It'd be nicer to describe the changes by hand anyway.

While the above would be my "dream goal", I am very happy with your annotations, which gets 99.9% done. +1 for merge.

PS: I don't recommend loading all three diffs at once in one browser tab... it takes a while and freezes :)

lep commented 6 months ago

At first i was introducing the patch annotation because there were actually steadily coming new natives and not every wc3 scene is playing the same patch. So if you asked me if annotating everything with patch 1.0 would be worth it, i would've said no. But seeing it now in person it's just nice seeing how things evolved over time. So thanks.

Leyki commented 5 months ago

Why didn't you include the betas?

I wasn't sure what to include and just like lep i was doubting wherever including 1.0, or even versions lower than 1.24 would be worth it, but decided for including everything minus betas for the sake of "completeness".

Luashine commented 5 months ago

There was a reason I had walked 500 miles to get all these game versions ;)