Closed Luashine closed 1 year ago
I think it's alright to have technical explanations. And the style is what we are currently doing anyways: attach the documentation to one specific native or type and explicitly link to it. I prefer that over duplicating documentation.
Stayed with official terminology, added links to fogstate
where they're explained. Ready for review.
There're a couple things I dont like about it, most importantly the terminology. I want to discuss this again and seriously.
This is called the Fog of War API. The FOW itself has 3 states (quoting my first draft here):
FOG_OF_WAR_MASKED
(1): Black mask, an unexplored map area.FOG_OF_WAR_FOGGED
(2): Haze, a previously explored map area that is currently not visible.FOG_OF_WAR_VISIBLE
(4): A fully visible map area.This seems fine until you begin dealing with individual function descriptions like FogMaskEnable, FogEnable. What I don't like about this is the ambiguous use of terms. On one hand this entire thing (API and concept) is called Fog of War. On the other hand, WC3 has the "mask vs fog" differentiation. In particular reusing "fog" seems to be a bad idea for clarity. It's not ideal to copy-paste this explanation everywhere.
I've asked in Hive Discord: GrapesOfWath would stay with these terms. Water would (probably) stay too but said this about my (over)simplification attempts (fair):
Options include: