lephare-photoz / lephare

LePHARE is a code for calculating photometric redshifts.
MIT License
4 stars 1 forks source link

Fixing a few minor doc/web page incongruities #186

Closed johannct closed 6 days ago

johannct commented 3 weeks ago

On the github page :

On pypi page :

johannct commented 3 weeks ago

being fixed in #187

johannct commented 3 weeks ago

I did not find yet where the name/email mismatch on PYPI is coming from.... It seems to come from lephare.egg-info/PKG-INFO so whatever creates this picks up the wrong info. @drewoldag perhaps?

drewoldag commented 3 weeks ago

Hi @johannct the best guess at this point is that the author field in setup.py is being picked up and added to PKG-INFO (which is then likely used to populate the Meta section of the PyPI page). I would assume that when you remove the setup.py file, that the first author will be picked up from the authors list in pyproject.toml.

I tested this locally on a not-lephare project, and was able to reproduce the behavior when I added a dummy setup.py file. Without this file, ther PKG-INFO includes only a author-email field, which hopefully would be interpreted correctly by PyPI.

You could try removing (or renaming) setup.py locally and then run pipx run build --sdist. You should then be able to examine the PKG-INFO file that is produced. The hypothesis is that the author-emails listed in PKG-INFO would be the same as those listed in pyproject.toml.

johannct commented 3 weeks ago

thanks @drewoldag , looks like your hint is spot on!

johannct commented 6 days ago

fixed in #187