Fix memory leak

[hdante]

Change Description

Hello, this fixes leaking SED instances if they still exist when calling the PhotoZ class destructor (this is the case when running lephare with pz-rail-lephare). The relevant leaks, shown by the address sanitizer:

Direct leak of 2358756400 byte(s) in 5360810 object(s) allocated from:
    #0 0x2b20a2157d77 in operator new(unsigned long) /opt/conda/conda-bld/gcc-compiler_1654084175708/work/gcc/libsanitizer/asan/asan_new_delete.cpp:99
    #1 0x2b20d6e0a224 in PhotoZ::read_lib(std::vector<SED*, std::allocator<SED*> >&, int&, int*, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&, std::vector<int, std::allocator<int> >, int&) /lustre/t1/cl/lsst/tmp/henrique.almeida/lephare/src/lib/photoz_lib.cpp:561

Direct leak of 77133056 byte(s) in 219128 object(s) allocated from:
    #0 0x2b20a2157d77 in operator new(unsigned long) /opt/conda/conda-bld/gcc-compiler_1654084175708/work/gcc/libsanitizer/asan/asan_new_delete.cpp:99
    #1 0x2b20d6e09dd1 in PhotoZ::read_lib(std::vector<SED*, std::allocator<SED*> >&, int&, int*, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&, std::vector<int, std::allocator<int> >, int&) /lustre/t1/cl/lsst/tmp/henrique.almeida/lephare/src/lib/photoz_lib.cpp:565

(...)
Direct leak of 1162304 byte(s) in 3302 object(s) allocated from:
    #0 0x2b20a2157d77 in operator new(unsigned long) /opt/conda/conda-bld/gcc-compiler_1654084175708/work/gcc/libsanitizer/asan/asan_new_delete.cpp:99
    #1 0x2b20d6e09472 in PhotoZ::read_lib(std::vector<SED*, std::allocator<SED*> >&, int&, int*, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&, std::vector<int, std::allocator<int> >, int&) /lustre/t1/cl/lsst/tmp/henrique.almeida/lephare/src/lib/photoz_lib.cpp:567

• [ ] My PR includes a link to the issue that I am addressing

Solution Description

Completed the destructor with the remaining de-allocations.

Code Quality

• [ ] I have read the Contribution Guide
• [x] My code follows the code style of this project
• [x] My code builds (or compiles) cleanly without any errors or warnings
• [ ] My code contains relevant comments and necessary documentation

Project-Specific Pull Request Checklists

Bug Fix Checklist

• [ ] My fix includes a new test that breaks as a result of the bug (if possible)
• [ ] My change includes a breaking change
  • [ ] My change includes backwards compatibility and deprecation warnings (if possible)

New Feature Checklist

• [ ] I have added or updated the docstrings associated with my feature using the NumPy docstring format
• [ ] I have updated the tutorial to highlight my new feature (if appropriate)
• [ ] I have added unit/End-to-End (E2E) test cases to cover my new feature
• [ ] My change includes a breaking change
  • [ ] My change includes backwards compatibility and deprecation warnings (if possible)

Documentation Change Checklist

• [ ] Any updated docstrings use the NumPy docstring format

Build/CI Change Checklist

• [ ] If required or optional dependencies have changed (including version numbers), I have updated the README to reflect this
• [ ] If this is a new CI setup, I have added the associated badge to the README

Other Change Checklist

• [ ] Any new or updated docstrings use the NumPy docstring format.
• [ ] I have updated the tutorial to highlight my new feature (if appropriate)
• [ ] I have added unit/End-to-End (E2E) test cases to cover any changes
• [ ] My change includes a breaking change
  • [ ] My change includes backwards compatibility and deprecation warnings (if possible)

[johannct]

thanks @hdante it seems very reasonable.

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 66.28%. Comparing base (23bea25) to head (7f420cb). Report is 6 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #193 +/- ## ========================================== + Coverage 66.26% 66.28% +0.02% ========================================== Files 50 50 Lines 6162 6166 +4 Branches 935 938 +3 ========================================== + Hits 4083 4087 +4 Misses 2079 2079 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[johannct]

You just need to avoid going to next line for pre-commit to be happy (strange that it chokes on that)

[johannct]

@hdante can you clear this, and perhaps add a test case that clear the 3 vector on destruction?

[raphaelshirley]

I made the changes to get precommit hooks passing. I was partly curious to see how that would work with a forked repository.

[hdante]

Thank you everyone,