lephare-photoz / lephare

LePHARE is a code for calculating photometric redshifts.
MIT License
5 stars 1 forks source link

Check that PDF::index behavior is really OK #203

Open johannct opened 1 month ago

johannct commented 1 month ago

https://github.com/lephare-photoz/lephare/blob/86fa1daae4fff37c47f6cf44cc0984da5ee55839/src/lib/PDF.cpp#L335

I am not convinced that it is ok to peg the incorrect input into the first and last bin. In the case of pdf this is going to increase the discrepancy in the QQ plot for instance, while the input not being in the range of the grid should be considered as a cause of concern no? At least for the cases where the xaxis is redshift.