lephare-photoz / lephare

LePHARE is a code for calculating photometric redshifts.
MIT License
5 stars 1 forks source link

Added 313 to PyPi publish #218

Closed raphaelshirley closed 1 week ago

raphaelshirley commented 2 weeks ago

Closes #215

We need to extend testing to match built versions.

Code Quality

Project-Specific Pull Request Checklists

Bug Fix Checklist

New Feature Checklist

Documentation Change Checklist

Build/CI Change Checklist

Other Change Checklist

raphaelshirley commented 2 weeks ago

Strange the c++ code coverage is now failing on the 3.10 test.

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 66.40%. Comparing base (ee3a99c) to head (0123193). Report is 7 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #218 +/- ## ========================================== - Coverage 66.65% 66.40% -0.25% ========================================== Files 50 50 Lines 6229 6225 -4 Branches 937 941 +4 ========================================== - Hits 4152 4134 -18 - Misses 2077 2091 +14 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

raphaelshirley commented 1 week ago

@johannct What do you think? It is passing all the tests after I changed one data retrieval test to acomodate Python 3.13. I also added a line to the lcov command to fix the issue that appeared out of nowhere. Finally I added recursive to the sdist commands but I think we'll have to publish to PyPI tp see if that has worked.

johannct commented 1 week ago

please merge and publish as 0.12. But we wont be able to test as now binaries are going to be available with py3.13

raphaelshirley commented 1 week ago

You can force from source https://pip.pypa.io/en/latest/cli/pip_install/#install-no-binary

raphaelshirley commented 1 week ago

I will add more commit comments going forward

johannct commented 1 week ago

You can force from source https://pip.pypa.io/en/latest/cli/pip_install/#install-no-binary

oh right, good catch

raphaelshirley commented 1 week ago

@johan I need an approving review to merge.

raphaelshirley commented 1 week ago

Ah you already did...