Closed raphaelshirley closed 1 month ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 66.66%. Comparing base (
0c42828
) to head (a19d8e1
). Report is 2 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
So the builds run but it does seem possibly odd that we make macos-13 builds for x86 and macos-14 builds for ARM64. Should we have both combinations? and or use 11+ given we aren't sure how well pypi builds from source. Perhaps we need some mac users with the given versions to test.
Also what about linux on arm hardware?
I am not sure this is correct as we now have multiple python versions for os 13 on x86 and multiple versions on os14 for ARM. Looking at astropy for each python version they just have os10.9+ for x86 and 11+ for arm. should we copy that instead?
I am curious to see if this passes all the tests
Possibly useful comparisons:
https://github.com/astropy/astropy/blob/main/.github/workflows/publish.yml https://pypi.org/project/astropy/#files
https://pypi.org/project/numpy/#files
Change Description
Solution Description
Code Quality
Project-Specific Pull Request Checklists
Bug Fix Checklist
New Feature Checklist
Documentation Change Checklist
Build/CI Change Checklist
Other Change Checklist