lephare-photoz / lephare

LePHARE is a code for calculating photometric redshifts.
MIT License
5 stars 1 forks source link

Converted every instance of macos-12 to macos-13 #225

Closed raphaelshirley closed 1 month ago

raphaelshirley commented 1 month ago

I am not sure this is correct as we now have multiple python versions for os 13 on x86 and multiple versions on os14 for ARM. Looking at astropy for each python version they just have os10.9+ for x86 and 11+ for arm. should we copy that instead?

I am curious to see if this passes all the tests

Possibly useful comparisons:

https://github.com/astropy/astropy/blob/main/.github/workflows/publish.yml https://pypi.org/project/astropy/#files

https://pypi.org/project/numpy/#files

Change Description

Solution Description

Code Quality

Project-Specific Pull Request Checklists

Bug Fix Checklist

New Feature Checklist

Documentation Change Checklist

Build/CI Change Checklist

Other Change Checklist

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 66.66%. Comparing base (0c42828) to head (a19d8e1). Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #225 +/- ## ========================================== + Coverage 66.61% 66.66% +0.04% ========================================== Files 50 50 Lines 6221 6434 +213 Branches 937 937 ========================================== + Hits 4144 4289 +145 - Misses 2077 2145 +68 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

raphaelshirley commented 1 month ago

So the builds run but it does seem possibly odd that we make macos-13 builds for x86 and macos-14 builds for ARM64. Should we have both combinations? and or use 11+ given we aren't sure how well pypi builds from source. Perhaps we need some mac users with the given versions to test.

raphaelshirley commented 1 month ago

Also what about linux on arm hardware?