lephisto / tesla-apiscraper

API Scraper for pulling Vehicle Statistics from the Tesla Owner API into an InfluxDB + Grafana Dashboards
GNU Lesser General Public License v3.0
364 stars 102 forks source link

Implement a fully-Dockerized setup. #8

Closed freerobby closed 5 years ago

freerobby commented 5 years ago

This is an alternate implementation of #5, with the following differences:

I'm not sure which approach is preferable for the project. I think @dailow's is better-suited to long-term installations (due to the customization of the data directory and the separation of concerns among containers), whereas mine excels at getting a working version up very quickly.

lephisto commented 5 years ago

Thanks for PR, I will test it, will last some days for sure.

lephisto commented 5 years ago

please pr again... sry for trouble..

freerobby commented 5 years ago

@lephisto No worries, but I'm not sure what the intention is here. Do you want me to just make a PR that reverts your revert?

freerobby commented 5 years ago

I will go ahead and do that, but feel free to close it out if that's not what you intended.

lephisto commented 5 years ago

I made a mistake prior merging your PR; so it was easier for me doing a reset --hard. thanks for contributing, will merge tomorrow.