search

lephong / mulrel-nel

named entity linking with latent relations
Apache License 2.0
172 stars 36 forks source link

dim inconsistent in use local only mode #7

Open hitercs opened 5 years ago

hitercs commented 5 years ago

Hi, Thanks for your work. https://github.com/lephong/mulrel-nel/blob/db14942450f72c87a4d46349860e96ef2edf353d/nel/mulrel_ranker.py#L153

I found that when config[use_local_only] = True, the code results in dimension inconsistent errors. That is caused by concating a zeros tensor with two scores. Is this a bug? Could you please fix it?

Thanks.

lephong commented 5 years ago

Thanks for letting me know. Let me fix it. In the mean time, if you are interested in only local local mode, you might want to have a look at https://github.com/dalab/deep-ed. Their local and our local models are identical.

hitercs commented 5 years ago

Great, thanks.