search

lephyrus / ngx-translate-messageformat-compiler

Advanced pluralization (and more) for ngx-translate, using standard ICU syntax which is compiled with the help of messageformat.js.
MIT License
93 stars 30 forks source link

Support messageformat v3 #74

Closed eshkard closed 2 years ago

eshkard commented 3 years ago

Hi npm shows warning on "messageformat" package renamed as @messageformat/core. Will you address this dependency issue?

"warning messageformat@2.3.0: Package renamed as '@messageformat/core', see messageformat.github.io for more details. 'messageformat' will eventually provide a polyfill for Intl.MessageFormat, once it's been defined by Unicode & ECMA."

Thank's, Evgeny

lephyrus commented 2 years ago

It's not just a renamed package - the new version has a number of breaking changes. I have to adapt a few things, shouldn't be hard.

lephyrus commented 2 years ago

Turns out the changes in messageformat v3 are anything but trivial for the way we use it, as a compiler at runtime. Don't expect this library to support v3 anytime soon, sorry.

tuuling commented 2 years ago

Turns out the changes in messageformat v3 are anything but trivial for the way we use it, as a compiler at runtime. Don't expect this library to support v3 anytime soon, sorry.

If someone were to provide a PR that supports v3, would you consider making a new major release with messageformat 3 support?

lephyrus commented 2 years ago

Sorry that support for messageformat v3 is still missing. It's actually pretty much done here: https://github.com/lephyrus/ngx-translate-messageformat-compiler/pull/83. I need to go back and make sure I really understand what behaves differently so there are no bad surprises. I should be able to do it in the coming days.