search

lephyrus / ngx-translate-messageformat-compiler

Advanced pluralization (and more) for ngx-translate, using standard ICU syntax which is compiled with the help of messageformat.js.
MIT License
93 stars 30 forks source link

Compile with Ivy #78

Closed lephyrus closed 2 years ago

PascalHonegger commented 2 years ago

Hey @lephyrus thanks for maintaining this library! Do you know when this Pull Request is expected to be ready? We're currently holding off on our Angular 13 upgrade because of this. If we can assist, e.g. by testing a pre-release, we would be happy to do so!

lephyrus commented 2 years ago

@PascalHonegger First off, the current version is compatible with Angular 13 already, but I guess you know that.

I have not merged/released this mainly because I want to check what the right peer dependencies are (I think partial-ivy works with Angular 12 or 13), and make sure it actually works with those in a minimal project. I should have time this weekend or next week at the latest. Good to know there's some interest!

tuuling commented 2 years ago

Or do like ngx-translate did their versions - have one version for ivy only?: v 5.x would be Angular 13 and up? https://github.com/ngx-translate/core#installation.

And thanks for this package. Doing gods work here!

lephyrus commented 2 years ago

@tuuling That's what I ended up doing. And thanks - glad to see the library is still useful for others too.