Various improvements - Githubissues

lepikhinb / laravel-typescript

MIT License

387 stars 46 forks source link

Various improvements #2

Closed chancezeus closed 3 years ago

chancezeus commented 3 years ago

Add support for custom paths (to load relevant items from 'vendor' folder)
Use explicit config values (with fallback) instead of spread operator in command
Add the "generate" command to Generator Contract (since this is what's actually called from the TypeScriptGenerator class)
Cleanup of generated code (additional white space, information message, etc)
A generator for FormRequest classes
TODO: Tests for request generator

lepikhinb commented 3 years ago

Thanks, Mark!

Any plans for the FormRequest tests? Once they're ready, we could add it to the default drivers in the config file and Readme.

chancezeus commented 3 years ago

Thanks for the commits and merge, I was working on it and thought why not share it. However didn't have time yet to write tests for the RequestGenerator, I did try it against a request including weirdly nested combinations and it seemed to work as expected (including array/object up to a few levels deep)...

If I find some spare time I'll add the tests as well but unfortunately I do have to do some other work for my day job for the next couple of days...

chancezeus commented 3 years ago

Just a thought (for future development) the trick I used for "custom" rules can also be applied to custom casts, that is add it as an array inside the config file and just make it a (simple) mapping of CustomCast::class => ['jsType1', 'jsType2']