search

lepoco / wpfui

WPF UI provides the Fluent experience in your known and loved WPF framework. Intuitive design, themes, navigation and new immersive controls. All natively and effortlessly.
https://wpfui.lepo.co
MIT License
7.04k stars 667 forks source link

Fixed the markup extension for the SymbolIcon and FontIcon class not working at all. #1067

Closed m0lDaViA closed 2 months ago

m0lDaViA commented 2 months ago

Pull request type

Please check the type of change your PR introduces:

What is the current behavior?

Currently you cannot use a markup extension for symbolicons or fonticons because the constructor does not accept the arguments.

grafik

What is the new behavior?

The markup extension for the symbolicon and fonticon class are now working with some small issue. grafik

Other information

So, I have now tested this extensively. I had previously closed this thread because for some reason the FontIcon markup extension randomly worked. However, I think that was due to VS (bugs and such). I also confused the FontIcon class with the SymbolIcon class in the thread (sorry x.x).

So: The markup extension needs a standard constructor without arguments. Furthermore, the existing constructor does not accept 2 arguments. Because of the bugs in VS, I wasn't sure before whether it was really a mistake in the markup extension (that's why i closed the last pull request), but now I am. The SymbolIcon markup extension had the same problem. The font size doesn't (forgot work), but it's not clear to me why. Maybe you know why @pomianowski ?

m0lDaViA commented 2 months ago

@pomianowski I have no idea why this commit went into this pull request :s Sorry for that, but i coulnd't even create another one.

So: As the arc class wasn't quite working so i thought "Why not? I do need it anyways.". The arc class had a few problems including that the arc had to be re-inserted (as a control) when the size was changed because a resize was not taken into account when rendering. That was the biggest problem that made me want to adapt these in the first place.

In the course of this, I thought it would be better for the user if he had the opportunity to edit both the sweepdirection and the penlinecap.

I also changed the starting position, from 3 a.m. to 12 a.m. I'll be happy to explain the reason for this: Ultimately, it is important to the user that it is as easy to use as possible. This also applies to programmers. And what's easier than a clock that you've known since birth?

If you don't agree and/or are satisfied with it, it can always be changed^^

ElectroAttacks commented 1 month ago

@m0lDaViA I found a new "feature" while using the NavigationView in LeftFluent mode. If you are using a different Font like Montserrat (which is actually quite big), you end up with a cut-off string, even if you increase the item size manually. I think it might be the ContentPresenter...