lepoco / wpfui

WPF UI provides the Fluent experience in your known and loved WPF framework. Intuitive design, themes, navigation and new immersive controls. All natively and effortlessly.
https://wpfui.lepo.co
MIT License
7.03k stars 666 forks source link

Added the HorizontalIconAlignment property to the button. #1117

Open m0lDaViA opened 3 weeks ago

m0lDaViA commented 3 weeks ago

Added the HorizontalIconAlignment property to the button. You can now choose, if you want to show the icon left or right to the content.

Pull request type

Please check the type of change your PR introduces:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

-

Other information

Jay-o-Way commented 3 weeks ago

Hm, the word "alignment" usually sounds like it is placed inside of a space. Like: text on a page is aligned inside/between the borders of the page. Not next to the page. Here, is more like a position relative to something else.

m0lDaViA commented 3 weeks ago

Hm, the word "alignment" usually should like it is placed inside of a space. Like: text on a page is aligned inside/between the borders of the page. Not next to the page. Here, is more like a position relative to something else.

But it isn't relative, that's the difference.

Jay-o-Way commented 3 weeks ago

What I mean is, the icon is placed to the left/right of the content/text. Therefore I think "HorizontalIconPlacement" would be a good (or even more accurate) wording.

By the way, I assume this works well in RTL language?

m0lDaViA commented 2 weeks ago

What I mean is, the icon is placed to the left/right of the content/text. Therefore I think "HorizontalIconPlacement" would be a good (or even more accurate) wording.

By the way, I assume this works well in RTL language?

In this case I followed the standard alignment that MS uses.

m0lDaViA commented 2 weeks ago

1120 & #887 can check the last commit.

m0lDaViA commented 1 week ago

I don't know why, but my vs is bugged rn. I cannot create visible styles and my formatter does instead of formatting only opened files all .xaml files. Sorry for that.