search

lepoco / wpfui

WPF UI provides the Fluent experience in your known and loved WPF framework. Intuitive design, themes, navigation and new immersive controls. All natively and effortlessly.
https://wpfui.lepo.co
MIT License
7.44k stars 723 forks source link

Light Mode: TabItem selected #238

Open jasmeet21 opened 2 years ago

jasmeet21 commented 2 years ago

Describe the bug
Light mode missing indication of which TabItem is selected

Expected behavior
On TabItem selection it should present darker color to represent which tab is selected

Screenshots
Light Mode: image

Dark Mode: image

Desktop (please complete the following information):

MajorXAML commented 2 years ago

Nope, the colors match the winui 3 style. But I would suggest removing the extra border at the bottom of the tabs.

image_2022-06-20_105655651

jasmeet21 commented 2 years ago

I have not closely look into winui 3 colors but i think your suggestion would be far better instead of changing color as i suggested. Thanks MajorXAML

ekdahl commented 2 years ago

Used a color picker to compare the two light examples.

The WPF UI screenshot: Selected tab color = FEFEFE (254) Not selected tab color = FBFBFB (251) Only 3 steps difference in the greyscale (I can hardly tell a difference on my monitor).

The WIN UI screenshot: Selected tab color = F9F9F9 (249) Not selected tab color = F3F3F3 (243) 6 steps difference in the greyscale.

The difference between selected and not selected tab is twice as big in the WIN UI and much easier to see (also thanks to the missing line as you say).

MajorXAML commented 2 years ago

@ekdahl The color picker will not work as it should because most colors in winui have varying degrees of transparency and their color depends on the background color.

In the case of TabView, the colors will be as follows: SolidBackgroundFillColorTertiaryBrush CardStrokeColorDefaultBrush