Version 2.4.5: added support for Locks

leporo / tornado-redis

Asynchronous Redis client that works within Tornado IO loop.

667 stars 163 forks source link

Version 2.4.5: added support for Locks #53

Closed advance512 closed 10 years ago

advance512 commented 10 years ago

I added support for Redis locks, with an async version of the interface as found in redis-py (https://github.com/andymccurdy/redis-py/blob/master/redis/client.py).

We have used it on Production servers here in Ev.me for the last few months.

leporo commented 10 years ago

Great job!

Could you, please:

rebase to the current tornado-redis master,
change a version to 2.4.15,
add a unit test using two instances of tornado-redis and callbacks to check if the second client acquires the lock only when the first one releases it?

I can also do it but as I'm really busy right now it may take a week or even more.

advance512 commented 10 years ago

Done as requested. Instead of using two tornado-redis instances and callbacks, I used two different Lock objects (it doesn't matter whether they're of the same or of a different client) and callbacks. It tests the code and the server properly.

Cheers!

leporo commented 10 years ago

Great! Thank you.