search

leppott / BioMonTools

Tools for biomonitoring and bioassessment; metric calculation for benthic macroinvertebrates, fish, and periphyton.
https://leppott.github.io/BioMonTools/
MIT License
13 stars 5 forks source link

metric.scores - input parameter col_IndexRegion should be col_IndexClass #103

Open leppott opened 7 months ago

leppott commented 7 months ago

Describe the bug Function metric.scores input parameter col_IndexRegion should be col_IndexClass

To Reproduce Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior A clear and concise description of what you expected to happen.

Screenshots image

Additional context When changed both BioMonTools and BCGcalc packages to use "Index_Class" and not "Index_Region" or other name (e.g., Site_Class) missed this one.

Will need to add a new input parameter to avoid breaking existing code that relies on the function (e.g., Shiny apps).

Place new variable, col_IndexClass, in the same slot and move col_IndexRegion to the end.

leppott commented 7 months ago

Ran PA Freestone IBI test and seems to work without error.

The example code has an error related to filter and single column data frames.